fix: Fixed dark-theme toggle not working in legacy pages #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reason for closing this PR? |
Hi @regisb , this PR was adding a guard to stop the dark theme file from executing twice. Later on, after debugging, I found out that the whole 'application' pipeline of js files was being imported twice in the instructor dashboard. So, I have opened a PR upstream on edx-platform to resolve this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dark theme toggle button was not working in the legacy pages because of the dark-theme.js file being executed twice as a VM file duplicate of dark-theme.js file is created by the browser so the event for onChange gets triggered twice. This PR puts a guard at the top of the file so that it only executes just once.
